RFR: 8256867: Classes with empty PermittedSubclasses attribute cannot be extended [v2]
Jan Lahoda
jlahoda at openjdk.java.net
Tue Dec 8 14:10:26 UTC 2020
On Tue, 8 Dec 2020 14:07:08 GMT, Harold Seigel <hseigel at openjdk.org> wrote:
>> Please review this fix for JDK-8256867. This change no longer throws a ClassFormatError exception when loading a class whose PermittedSubclasses attribute is empty (contains no classes). Instead, the class is treated as a sealed class which cannot be extended nor implemented. This new behavior conforms to the JVM Spec.
>>
>> This change required changing Class.permittedSubclasses() to return an empty array for classes with empty PermittedSubclasses attributes, and to return null for non-sealed classes.
>>
>> This fix was tested with Mach5 tiers 1-2 on Linux, MacOS, and Windows, and tiers 3-5 on Linux x64.
>>
>> Thanks, Harold
>
> Harold Seigel has updated the pull request incrementally with one additional commit since the last revision:
>
> 8256867: Classes with empty PermittedSubclasses attribute cannot be extended
The langtools changes look good to me - thanks!
-------------
Marked as reviewed by jlahoda (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/1675
More information about the core-libs-dev
mailing list