RFR: JDK-8212035 : merge jdk.test.lib.util.SimpleHttpServer with jaxp.library.SimpleHttpServer [v2]

Mahendra Chhipa github.com+34924738+mahendrachhipa at openjdk.java.net
Tue Dec 8 16:51:05 UTC 2020


On Fri, 4 Dec 2020 20:48:01 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:

>> test/jdk/sun/net/www/protocol/jar/MultiReleaseJarURLConnection.java line 80:
>> 
>>> 78:         creator.buildSignedMultiReleaseJar();
>>> 79: 
>>> 80:         server = new SimpleHttpServer(TESTCONTEXT,System.getProperty("user.dir", "."));
>> 
>> Please add space after comma.
>
> I believe the InetAddress parameter should be preserved in order to allow test to specifically bind to the loopback address instead of the wildcard (binding to the wildcard has been a source of test instability in the past).

Thanks. Review comments are fixed in next patch

-------------

PR: https://git.openjdk.java.net/jdk/pull/1632


More information about the core-libs-dev mailing list