Integrated: 8257876: Avoid Reference.isEnqueued in tests

Kim Barrett kbarrett at openjdk.java.net
Thu Dec 10 10:37:55 UTC 2020


On Tue, 8 Dec 2020 09:52:51 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

> Please review this change that eliminates the use of Reference.isEnqueued by
> tests.  There were three tests using it:
> 
> vmTestbase/gc/gctests/ReferencesGC/ReferencesGC.java
> vmTestbase/gc/gctests/WeakReferenceGC/WeakReferenceGC.java
> jdk/java/lang/ref/ReferenceEnqueue.java
> 
> In each of them, some combination of using Reference.refersTo and
> ReferenceQueue.remove with a timeout were used to eliminate the use of
> Reference.isEnqueued.
> 
> I also cleaned up ReferencesGC.java in various respects.  It contained
> several bits of dead code, and the failure checks were made stronger.
> 
> Testing:
> mach5 tier1
> Locally (linux-x64) ran all three tests with each GC (including Shenandoah).

This pull request has now been integrated.

Changeset: db5da961
Author:    Kim Barrett <kbarrett at openjdk.org>
URL:       https://git.openjdk.java.net/jdk/commit/db5da961
Stats:     104 lines in 3 files changed: 23 ins; 39 del; 42 mod

8257876: Avoid Reference.isEnqueued in tests

Reviewed-by: mchung, tschatzl

-------------

PR: https://git.openjdk.java.net/jdk/pull/1691


More information about the core-libs-dev mailing list