RFR: 8251989: Hex formatting and parsing utility [v19]

Daniel Fuchs dfuchs at openjdk.java.net
Fri Dec 11 16:16:07 UTC 2020


On Wed, 9 Dec 2020 16:46:54 GMT, Roger Riggs <rriggs at openjdk.org> wrote:

>> java.util.HexFormat utility:
>> 
>>  - Format and parse hexadecimal strings, with parameters for delimiter, prefix, suffix and upper/lowercase
>>  - Static factories and builder methods to create HexFormat copies with modified parameters.
>>  - Consistent naming of methods for conversion of byte arrays to formatted strings and back: formatHex and parseHex
>>  - Consistent naming of methods for conversion of primitive types: toHexDigits... and fromHexDigits...
>>  - Prefix and suffixes now apply to each formatted value, not the string as a whole
>>  - Using java.util.Appendable as a target for buffered conversions so output to Writers and PrintStreams
>>    like System.out are supported in addition to StringBuilder. (IOExceptions are converted to unchecked exceptions)
>>  - Immutable and thread safe, a "value-based" class
>> 
>> See the [HexFormat javadoc](http://cr.openjdk.java.net/~rriggs/8251989-hex-formatter/java.base/java/util/HexFormat.html) for details.
>> 
>> Review comments and suggestions welcome.
>
> Roger Riggs has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Clarified parsing of hex as unsigned in fromHexDigits methods.

Changes requested by dfuchs (Reviewer).

src/java.base/share/classes/java/util/HexFormat.java line 961:

> 959:      * characters.
> 960:      * The characters in the range {@code fromIndex} to {@code toIndex}, exclusive,
> 961:      * are parsed are parsed from most significant to least significant

Is there some stuttering here? `are parsed are parsed` ;-)

-------------

PR: https://git.openjdk.java.net/jdk/pull/482


More information about the core-libs-dev mailing list