RFR: JDK-8223322: Improve concurrency in jpackage instances
Andy Herrick
herrick at openjdk.java.net
Fri Dec 18 15:43:39 UTC 2020
On Fri, 18 Dec 2020 15:00:13 GMT, Andy Herrick <herrick at openjdk.org> wrote:
>>>
>>>
>>> I'd propose to update the test to run more that two concurrent instance of jpackage command.
>>
>> yes - I'm planning for a lot more in next revision, your suggestion to use only PackageTest.Action.CREATE will go a long way to making that possible, but I have had problems with test infrastructure fixing the workDir based on test class and method, and then getting IOExceptions as various PackageTest's try to write the same content to the same work dir. I need to create infrastructure to allow each PackageTest to operate on separate workDir.
>
> Reverting this PR to DRAFT while the above suggestions are implemented.
>
>
> .removeArgumentWithValue("--type") can be used to make jpackage create default native package. This will eliminate need to introduce packageType.getDefault() method.
The above will cause an exception from JPackageCommand.execute() > ... > JPackageCommand.verifyIsOfType(), but perhaps that problem will go away if only JPackageTest.run(PackageTest.Action.CREATE) is used.
-------------
PR: https://git.openjdk.java.net/jdk/pull/1829
More information about the core-libs-dev
mailing list