RFR: 8258584: java/util/HexFormat/HexFormatTest.java fails on x86_32 [v3]

[Roger Riggs]

On Mon, 21 Dec 2020 23:37:08 GMT, Jie Fu <jiefu at openjdk.org> wrote:

>> Hi all,
>> 
>> java/util/HexFormat/HexFormatTest.java fails on x86_32 due to '-Xmx4G'.
>> The reason is that -Xmx4G is invalid maximum heap size for 32-bit platforms.
>> The current implementation only supports maximum 3800M on 32-bit systems [1].
>> 
>> I've tried to reduce the -Xmx size, but it still fails even with -Xmx2G.
>> So this test seems to be brittle on 32-bit platforms since 2G is already larger than 3800M/2=1900M.
>> The fix just skips the test for 32-bit systems.
>> 
>> Thanks.
>> Best regards,
>> Jie
>> 
>> [1] https://github.com/openjdk/jdk/blob/master/src/hotspot/os/posix/os_posix.cpp#L567
>
> Jie Fu has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Skip OOME

Looks fine.  Thanks

-------------

Marked as reviewed by rriggs (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/1817