RFR [16/java.xml] 8248486: SafeThread illegal access to java.lang private fields should be removed

Mandy Chung mandy.chung at oracle.com
Fri Jul 10 16:59:36 UTC 2020


Hi Joe,

The change looks good.   You can consider using AtomicInteger for the 
thread number.  Looks like this is the only use of jdk.internal.misc 
from java.xml.   You can remove the qualified exports from java.base to 
java.xml.

$ ./bin/jdeps -verbose:class -p jdk.internal.misc modules/java.xml
java.xml
:
java.xml -> java.base
    com.sun.org.apache.xml.internal.utils.SafeThread   -> 
jdk.internal.misc.Unsafe                           java.base (qualified)

Mandy

On 7/10/20 9:38 AM, Chris Hegarty wrote:
>
>> On 9 Jul 2020, at 23:23, huizhe.wang at oracle.com wrote:
>>
>> ...
>>
>> webrev: http://cr.openjdk.java.net/~joehw/jdk16/8248486/webrev/
>>
> Looks good. Reviewed.
>
> -Chris.



More information about the core-libs-dev mailing list