RFR[15/java.xml] Re: RFR [16/java.xml] 8248486: SafeThread illegal access to java.lang private fields should be removed

[Alan Bateman]

On 12/07/2020 23:21, Joe Wang wrote:
> Hi all,
>
> Alan updated the bug to indicate it fails since JDK 9. Given we still 
> have a couple days for JDK 15, I've rebased the patch to the jdk15 
> repo and would like to check in the patch into JDK 15 instead (and let 
> it be sync-ed to 16). Here's the webrev for JDK 15:
>
> http://cr.openjdk.java.net/~joehw/jdk15/8248486/webrev/
>
> No change to the SafeThread. The change to module-info.java was made 
> by deleting java.xml from its JDK15 version. Please review.
I was curious how we didn't spot this in JDK 9 but it's using Unsafe to 
get an offset to these fields so that explains it. Good to get this 
technical debt fixed as there is no guarantee that the hack will work in 
the future. I don't think there is any urgency for JDK 15 though, fixing 
it in the main line for JDK 16 is fine.

-Alan