RFR: 8245527: LDAP Cnannel Binding support for Java GSS/Kerberos

[Daniel Fuchs]

Hi Alexey,

On 10/07/2020 21:37, Alexey Bakhtin wrote:
> Updated webrev:http://cr.openjdk.java.net/~abakhtin/8245527/webrev.v14/

In what the JNDI part is concerned this looks good to me now.

nit: 
java.naming/share/classes/com/sun/jndi/ldap/sasl/TlsChannelBinding.java:
  138         }catch(NoSuchAlgorithmException | 
CertificateEncodingException e) {

missing spaces around `catch`; No need for a new webrev.

Please make sure to update the CSR, and in particular update
the specification section with the diffs from

src/java.naming/share/classes/module-info.java

Also I am not sure the links that are currently in the
specification section are at their place. They may be better
placed in the Solution section (the solution is to implement
the client part of the channel binding as described by these
documents in the default JNDI/LDAP/GSS provider).

Since we don't really have any end-to-end regression test
(what we have is mostly a smoke test) - it would be good if
you could describe in more details what you did to test your
fix against a real server in a JBS comment in JDK-8245527 - so
that someone (future or current maintainers) could reproduce
this testing to verify that nothing is broken by future evolutions.
In particular - if anything specific needs to be
installed/configured on the test machine (LDAP server? Which?
Is that all?)


best regards,

-- daniel