Fwd: RFR: JDK-8249258 java/util/StringJoiner/StringJoinerTest.java failed due to OOM (JDK 15)
Roger Riggs
Roger.Riggs at oracle.com
Tue Jul 14 19:35:21 UTC 2020
Looks good.
Though it does seem like the VM should have been able to reclaim enough
memory between tests
to not need to throw OOME.
Thanks, Roger
On 7/14/20 2:23 PM, Daniel D. Daugherty wrote:
> On 7/14/20 2:09 PM, Jim Laskey wrote:
>> Adding Daniel
>>
>>> Begin forwarded message:
>>>
>>> *From: *Jim Laskey <james.laskey at oracle.com
>>> <mailto:james.laskey at oracle.com>>
>>> *Subject: **RFR: JDK-8249258
>>> java/util/StringJoiner/StringJoinerTest.java failed due to OOM (JDK
>>> 15)*
>>> *Date: *July 14, 2020 at 2:01:09 PM ADT
>>> *To: *core-libs-dev <core-libs-dev at openjdk.java.net
>>> <mailto:core-libs-dev at openjdk.java.net>>
>>>
>>> The test was failing on a newly added mac mini. I've reduced the
>>> memory stress by introducing a shared maximum sized string. I don't
>>> recommend reducing the 4G memory requirement -- multiple new large
>>> objects are constructed in the tests hoping to create an OOM.
>>>
>>> JBS: https://bugs.openjdk.java.net/browse/JDK-8249258
>>> webrev: http://cr.openjdk.java.net/~jlaskey/8249258/webrev-01
>
> test/jdk/java/util/StringJoiner/StringJoinerTest.java
> No comments on the changes.
>
> This should make it less likely to cause an OOM in an unexpected place.
> Thanks for fixing this so quickly.
>
> Thumbs up. Don't know if your team updates copyrights as you
> touch files, but if you do, then this one needs it...
>
> Dan
>
>
>>>
>>>
>>>
>>>
>>>
>>
>
More information about the core-libs-dev
mailing list