RFR: JDK-8249289: Exception thrown when --temp points to non-existant directory
alexander.matveev at oracle.com
alexander.matveev at oracle.com
Thu Jul 16 21:38:20 UTC 2020
Hi Andy,
Looks good.
Thanks,
Alexander
On 7/16/20 11:44 AM, Andy Herrick wrote:
> yes - revised as suggested - please re review.
>
> /Andy
>
> On 7/15/2020 6:41 PM, alexander.matveev at oracle.com wrote:
>> Hi Andy,
>>
>> Can you double check two other places where File.list() was
>> introduced with JDK-8223955 for similar issues?
>> One in MacPkgBundler.java and second in DeployParams.java.
>>
>> Thanks,
>> Alexander
>>
>> On 7/15/20 3:09 PM, Alexey Semenyuk wrote:
>>> Andy,
>>>
>>> Stream.close() call is missing on the result of Files.list() call.
>>> I'd also replace Files.list(root) with Files.walk(root, 1) call to
>>> eliminate diving in directory tree.
>>>
>>> - Alexey
>>>
>>> On 7/15/2020 2:37 PM, Andy Herrick wrote:
>>>> Please review the jpackage fix for issue [1] at [2].
>>>>
>>>> This fixes the regression in JDK16 which caused exception when an
>>>> empty directory was used int the --temp jpackage option, and added
>>>> to the existing test.
>>>>
>>>> [1] - https://bugs.openjdk.java.net/browse/JDK-8249289
>>>>
>>>> [2[ - http://cr.openjdk.java.net/~herrick/8249289/webrev.02/
>>>>
>>>> /Andy
>>>>
>>>
>>
More information about the core-libs-dev
mailing list