RFR: 8245311: [macos] misc package tests failed due to "execution error: Finder got an error: AppleEvent timed out."

[Alexey Semenyuk]

Alexander,

The change in RetryExecutor.java results in Executor instance created 
only once and not every time command line should be executed.

I'd suggest to have
---
void execute(String cmdline[]) throws IOException {
     executeLoop(() -> Executor.of(cmdline));
}

private void executeLoop(Supplier<Executor> execSupplier) throws 
IOException {
      ...
      Executor exec = execSupplier.get();
}
---

instead.

- Alexey

On 7/17/2020 1:03 PM, Andy Herrick wrote:
> Looks OK - I approve.
>
> /Andy
>
> On 7/15/2020 7:29 PM, alexander.matveev at oracle.com wrote:
>> Please review the jpackage fix for bug [1] at [2].
>>
>> - "hdiutil detach" resource busy error is fixed in same way as 
>> JDK-8242786 by repeating detach several times.
>> - pkgbuild timeout will be covered with JDK-8249395.
>>
>> [1] https://bugs.openjdk.java.net/browse/JDK-8245311
>> [2] http://cr.openjdk.java.net/~almatvee/8245311/webrev.00/
>>
>> Thanks,
>> Alexander