JDK 16 RFR of JDK-8250237: Address use of default constructors in the javax.script package

sundararajan.athijegannathan at oracle.com sundararajan.athijegannathan at oracle.com
Fri Jul 24 01:19:25 UTC 2020


Looks good

-Sundar

On 24/07/20 2:54 am, Joe Darcy wrote:
> Hello,
>
> One class in the javax.script package uses a default constructor; 
> please review the patch below and CSR 
> (https://bugs.openjdk.java.net/browse/JDK-8250239) to replace it with 
> an explicit constructor.
>
> Thanks,
>
> -Joe
>
> diff -r d62da6fc4074 
> src/java.scripting/share/classes/javax/script/CompiledScript.java
> --- 
> a/src/java.scripting/share/classes/javax/script/CompiledScript.java 
> Thu Jul 23 20:25:41 2020 +0100
> +++ 
> b/src/java.scripting/share/classes/javax/script/CompiledScript.java 
> Thu Jul 23 14:15:08 2020 -0700
> @@ -1,5 +1,5 @@
>  /*
> - * Copyright (c) 2005, 2013, Oracle and/or its affiliates. All rights 
> reserved.
> + * Copyright (c) 2005, 2020, Oracle and/or its affiliates. All rights 
> reserved.
>   * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
>   *
>   * This code is free software; you can redistribute it and/or modify it
> @@ -42,6 +42,10 @@
>   * @since 1.6
>   */
>  public abstract class CompiledScript {
> +    /**
> +     * Constructor for subclasses to call.
> +     */
> +    public CompiledScript() {}
>
>      /**
>       * Executes the program stored in this 
> <code>CompiledScript</code> object.
>


More information about the core-libs-dev mailing list