8248248: [macos] EmptyFolderPackageTest.java fails EmptyFolderPackageTest-dmg-setup.scpt exited with 134 code

[Andy Herrick]

looks good.

/Andy

On 7/23/2020 7:17 PM, alexander.matveev at oracle.com wrote:
> http://cr.openjdk.java.net/~almatvee/8248248/webrev.01/
>
> - Added INFINITE_TIMEOUT instead of -1.
> - Fix actually did not work correctly and process never timeout, since 
> we were reading process output and wait with timeout never executed, 
> since reading output was continue until process terminated. Fix by 
> forcing using file for output, since in this case we will wait for 
> process before reading output.
>
> Thanks,
> Alexander
>
> On 7/20/20 1:49 PM, Alexey Semenyuk wrote:
>> Looks good.
>>
>> Minor suggestion: introduce a constant for infinite timeout and use 
>> it instead of "-1".
>>
>> - Alexey
>>
>> On 7/20/2020 4:43 PM, alexander.matveev at oracle.com wrote:
>>> Please review the jpackage fix for bug [1] at [2].
>>>
>>> It is not clear why script was hanging for more than 7 minutes which 
>>> caused test to timeout. Fixed by limiting script execution time to 3 
>>> minutes. Also, EmptyFolderPackageTest was removed from ProblemList.
>>>
>>> [1] https://bugs.openjdk.java.net/browse/JDK-8248248
>>> [2] http://cr.openjdk.java.net/~almatvee/8248248/webrev.00/
>>>
>>> Thanks,
>>> Alexander
>>
>