Build error with GCC 10 in NetworkInterface.c and k_standard.c

Koichi Sakata sakatakui at oss.nttdata.com
Thu Jul 30 14:10:07 UTC 2020


 >> We don't need it; this is ancient history. Nonetheless, feel free to
 >> be consistent with the old style. I'll approve it.

I understand. Thank you, Andrew!

On 2020/07/30 21:13, Yasumasa Suenaga wrote:
> Hi Koichi,
> 
> Looks good your change.
> 
> BTW have you got a sponsor?
> I will sponsor you if you do not have yet.
> 
> 
> Thanks,
> 
> Yasumasa

I haven't found a sponsor yet. So I would appreciate it if you could 
sponsor this patch.

Thanks,
Koichi


> 
> 
> On 2020/07/30 18:45, Andrew Haley wrote:
>> On 7/30/20 6:58 AM, Koichi Sakata wrote:
>>> I just formatted the patch to be same as the other code.
>>>
>>> Moreover, I saw the following code in k_standard.c.
>>>
>>> if (_LIB_VERSION == _SVID_)
>>>     exc.retval = zero;
>>> else
>>>     exc.retval = zero/zero;
>>>
>>> Do we need to do like that in this patch? It seems to be related to the
>>> old matherr(), but I'm not sure about that.
>>
>> We don't need it; this is ancient history. Nonetheless, feel free to
>> be consistent with the old style. I'll approve it.
>>


More information about the core-libs-dev mailing list