[15] RFR(S) : 6501010 : test/java/io/File/GetXSpace.java fails on Windows

Brian Burkhalter brian.burkhalter at oracle.com
Thu Jul 30 21:39:57 UTC 2020


Hi Igor,

This test looks all right to me.

Sorry for the late review.

Thanks,

Brian

> On Jul 20, 2020, at 11:28 AM, Igor Ignatyev <igor.ignatyev at oracle.com> wrote:
> 
> http://cr.openjdk.java.net/~iignatyev//6501010/webrev.00 <http://cr.openjdk.java.net/~iignatyev//6501010/webrev.00>
>> 98 lines changed: 18 ins; 31 del; 49 mod;
> 
> Hi all,
> 
> could you please review this small fix to make java/io/File/GetXSpace.java work again on windows?
> 
> the test has been updated to work under cygwin, which includes the following changes:
> - GetXSpace.sh accepts CYGWIN_* as known OS and sets windows path to TMP var
> - uses the same regexp to parse df on windows as on other platforms
> - but uses 'FileSystem' field as Space's name, as opposed to 'MountedOn' on *nix, as on cygwin, MountedOn is cygwin path, while FileSystem is corresponding windows path, and the test expect Space's name to be appropriate path



More information about the core-libs-dev mailing list