RFR: JDK-8222241 - Example in ServiceLoader API docs should have one provides directive

Fernando Guallini fernando.guallini at oracle.com
Tue Jun 2 14:06:14 UTC 2020


Sure, added indentation here: http://cr.openjdk.java.net/~pconcannon/fguallin/8222241/webrevs/webrev.01/ <http://cr.openjdk.java.net/~pconcannon/fguallin/8222241/webrevs/webrev.01/>

This is how the html is rendered:






Thanks



> On 29 May 2020, at 19:00, Alan Bateman <Alan.Bateman at oracle.com> wrote:
> 
> On 29/05/2020 18:12, Fernando Guallini wrote:
>> Hi,
>> in the ServiceLoader API docs, the given example specifying the service providers for a particular service should be comma-separated instead of using two separate ‘provides’ directives, that would result in a compilation error.
>> 
>> Web rev: http://cr.openjdk.java.net/~pconcannon/fguallin/8222241/webrevs/webrev.00/ <http://cr.openjdk.java.net/~pconcannon/fguallin/8222241/webrevs/webrev.00/>
>> 
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8222241 <https://bugs.openjdk.java.net/browse/JDK-8222241>
>> 
> Yes, it should be one `provides` directive. Can you intend the second class name to make the code fragment a bit more readable in the generated javadoc?
> 
> -Alan



More information about the core-libs-dev mailing list