RFR: JDK-824662: Refactor JLinkBundlerHelper and StandardBundlerParam classes
alexander.matveev at oracle.com
alexander.matveev at oracle.com
Thu Jun 4 23:33:52 UTC 2020
Hi Alexey,
Looks good.
Thanks,
Alexander
On 6/4/20 1:22 PM, Alexey Semenyuk wrote:
> Please review fix [2] for jpackage bug [1].
>
> Move functionality to collect data about app (main class name, main
> jar, module name, etc) from JLinkBundlerHelper and
> StandardBundlerParam classes in dedicated LauncherData class.
> Remove ArgAction, ModFile and RelativeFileSet classes as they are not
> needed any more after refactoring of JLinkBundlerHelper and
> StandardBundlerParam classes.
> Clean unused code.
>
> - Alexey
>
> [1] https://bugs.openjdk.java.net/browse/JDK-8246624
>
> [2] http://cr.openjdk.java.net/~asemenyuk/8246624/webrev.00
>
More information about the core-libs-dev
mailing list