RFR(S/T) : 8245874 : requires.extraPropDefns.vmOpts doesn't need -Xbootclasspath/a:bootClasses

Vladimir Ivanov vladimir.x.ivanov at oracle.com
Fri Jun 5 08:02:17 UTC 2020


Looks good.

Best regards,
Vladimir Ivanov

On 27.05.2020 20:25, Igor Ignatyev wrote:
> http://cr.openjdk.java.net/~iignatyev//8245874/webrev.00
>> 8 lines changed: 2 ins; 0 del; 6 mod;
> 
> Hi all,
> 
> could you please review this small and trivial cleanup in TEST.ROOT files of test/jdk/ and test/hotspot/jtreg test suites?
> from JBS:
>> to make sure that classes listed in `requires.extraPropDefns.bootlibs` are in BCP, jtreg automatically adds corresponding `-Xbootclasspath/a:` to the options list, so `requires.extraPropDefns.vmOpts` doesn't have to have `-Xbootclasspath/a:bootClasses`
> the patch
>   - removes -Xbootclasspath/a:bootClasses from requires.extraPropDefns.vmOpts
>   - moves jdk.test.lib.Platform and Container classes from requires.extraPropDefns.bootlibs to requires.extraPropDefns.libs as there is no need for them to be in BCP
> 
> JBS: https://bugs.openjdk.java.net/browse/JDK-8245874
> testing: tier1
> webrev: http://cr.openjdk.java.net/~iignatyev//8245874/webrev.00
> 
> Thanks,
> -- Igor
> 


More information about the core-libs-dev mailing list