RFR: 8233215: jpackage doesn't allow enough flexibility for file type binding

Alexey Semenyuk alexey.semenyuk at oracle.com
Tue Jun 9 12:39:36 UTC 2020


Looks good.

- Alexey

On 6/9/2020 2:28 AM, alexander.matveev at oracle.com wrote:
> Hi Alexey,
>
> http://cr.openjdk.java.net/~almatvee/8233215/webrev.01/
>
> - TKit.assertStringListEquals() will be used instead. Did not noticed 
> that we had this method already. I removed my implementation.
> - Added "mac." prefix.
>
> Thanks,
> Alexander
>
> On 6/8/20 10:57 PM, Alexey Semenyuk wrote:
>> Alexander,
>>
>> There is TKit.assertStringListEquals() already. Is it not sufficient?
>>
>> I think it would make sense to add prefix to platform specific 
>> properties in fa property files: `CFBundleTypeRole` -> 
>> `mac.CFBundleTypeRole`, etc.
>>
>> - Alexey
>>
>> On 6/9/2020 1:12 AM, alexander.matveev at oracle.com wrote:
>>> Please review the jpackage fix for bug [1] at [2].
>>>
>>> Added support for additional (macOS specific) file association 
>>> properties. These additional properties should be set via same 
>>> property file which used for file association. Names and values for 
>>> properties should match name and values as documented by Apple in 
>>> https://developer.apple.com/documentation/bundleresources/information_property_list/cfbundledocumenttypes. 
>>> jpackage will simple propagate these values to Info.plist as is.
>>>
>>> [1] https://bugs.openjdk.java.net/browse/JDK-8233215
>>> [2] http://cr.openjdk.java.net/~almatvee/8233215/webrev.00/
>>>
>>> Thanks,
>>> Alexander
>>
>



More information about the core-libs-dev mailing list