RFR: 8246129: ZIP entries created for DOS epoch include local timezone metadata

Martin Buchholz martinrb at google.com
Tue Jun 9 15:51:51 UTC 2020


not really a review, but cautions:

I was afraid that might be hard to fix because DOSTIME_BEFORE_1980 was
used as a special value indicating that the real time was < 1980 and
stored in an extra field.  But I guess we now don't have any code that
makes assumptions based only on DOSTIME_BEFORE_1980?

Keep in mind that dostime is local date time, and there's always risk
in the zip code of confusing time-zoned date time with un-zoned.

On Tue, Jun 9, 2020 at 8:24 AM Claes Redestad <claes.redestad at oracle.com> wrote:
>
> Hi,
>
> this patch addresses a corner case where extra time stamp information
> is added when using start of the DOS time epoch (1980-01-01 00:00:00)
> as a dummy timestamp for entries
>
> Bug:    https://bugs.openjdk.java.net/browse/JDK-8246129
> Webrev: http://cr.openjdk.java.net/~redestad/8246129/open.00/
>
> Testing: tier1-2
>
> Thanks!
>
> /Claes


More information about the core-libs-dev mailing list