RFR [15/java.xml] 8237456: Transform filtered through SAX filter mishandles character entities

[Joe Wang]

Thanks Aleksei, Lance!

I'm using NetBeans, but I may get back to Intellij once my new machine 
arrives :-)

-Joe

On 6/9/2020 5:41 AM, Lance Andersen wrote:
> Hi Joe,
>
> This looks good.
>
> For your test,  Intellij typically suggests using a static import for 
> Assert:
>
> ——————
> import static org.testng.Assert.*;
>
> —————————
>
> No need to change but typically which get suggested when you run 
> Inspect Code
>
> Best
> Lance
>
>> On Jun 9, 2020, at 1:54 AM, Joe Wang <huizhe.wang at oracle.com 
>> <mailto:huizhe.wang at oracle.com>> wrote:
>>
>> Hi,
>>
>> Please review a fix to a regression that resulted in invalid output 
>> in a transform that contains entity references. The regression was 
>> caused by a JDK9 patch [1]. Adding back the conditional checks fixed 
>> the issue.
>>
>> JBS: https://bugs.openjdk.java.net/browse/JDK-8237456
>> webrevs: http://cr.openjdk.java.net/~joehw/jdk15/8237456/webrev/
>>
>> [1] https://bugs.openjdk.java.net/browse/JDK-8087303
>>
>> Thanks,
>> Joe
>>
>
> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
> <http://oracle.com/us/design/oracle-email-sig-198324.gif><http://oracle.com/us/design/oracle-email-sig-198324.gif>
> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance 
> Andersen| Principal Member of Technical Staff | +1.781.442.2037
> Oracle Java Engineering
> 1 Network Drive
> Burlington, MA 01803
> Lance.Andersen at oracle.com <mailto:Lance.Andersen at oracle.com>
>
>
>