RFR 8247274: (test) HexPrinter cleanup

[Roger Riggs]

Thanks Lance

On 6/10/20 12:53 PM, Lance Andersen wrote:
> Hi Roger,
>
> I think your changes look fine.
>
>
> Best
> Lance
>
>> On Jun 9, 2020, at 6:47 PM, Roger Riggs <Roger.Riggs at oracle.com 
>> <mailto:Roger.Riggs at oracle.com>> wrote:
>>
>> Please review cleanup to the test support for 
>> jdk.test.lib.hexprinter.HexPrinter.
>>
>> Correct issues with the test support for jdk.test.lib.hexdump.HexPrinter.
>>  - Correct the swapped definitions of Formatters.ASCII and PRINTABLE
>>    Printable should always return a single character,
>>    ASCII provides mnemonics to be consistent with the command line 
>> hexdump.
>> - For the methods to format ByteBuffers align the descriptions of the 
>> index and length to match ByteBuffer.
>>  - Correctly implement the extraction of bytes from the ByteBuffer
>>  - a newline in the annotation should print as '\n' instead of 
>> causing a line break
>>
>> Webrev:
>> http://cr.openjdk.java.net/~rriggs/webrev-hexprinter-8247274-1/
>> Issue:
>> https://bugs.openjdk.java.net/browse/JDK-8247274
>>
>> Thanks, Roger
>
> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
> <http://oracle.com/us/design/oracle-email-sig-198324.gif><http://oracle.com/us/design/oracle-email-sig-198324.gif>
> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance 
> Andersen| Principal Member of Technical Staff | +1.781.442.2037
> Oracle Java Engineering
> 1 Network Drive
> Burlington, MA 01803
> Lance.Andersen at oracle.com <mailto:Lance.Andersen at oracle.com>
>
>
>