RFR 6470126 java.util.jar.Attributes#containsKey fails with Strings
Vipin Mv1
vipinmv1 at in.ibm.com
Mon Jun 15 06:22:28 UTC 2020
Hi,
I have addressed the review comments and the patch has been uploaded here:
http://cr.openjdk.java.net/~vtewari/6470126/webrev/index.html
Please let me know your suggestions.
Thanks & Regards
Vipin MV
-----Vipin Mv1/India/IBM wrote: -----
To: core-libs-dev at openjdk.java.net
From: Vipin Mv1/India/IBM
Date: 05/11/2020 05:00PM
Subject: RFR 6470126 java.util.jar.Attributes#containsKey fails with Strings
Hi,
Please review the fix for the following issue.
https://bugs.openjdk.java.net/browse/JDK-6470126
diff -r 53568400fec3 src/java.base/share/classes/java/util/jar/Attributes.java
--- a/src/java.base/share/classes/java/util/jar/Attributes.java Thu Mar 26 15:26:51 2020 +0000
+++ b/src/java.base/share/classes/java/util/jar/Attributes.java Mon May 11 15:00:01 2020 +0530
@@ -205,7 +205,10 @@
* @return true if this Map contains the specified attribute name
*/
public boolean containsKey(Object name) {
- return map.containsKey(name);
+ if(String.class.isInstance(name))
+ return map.containsKey(Name.of((String)name));
+ else
+ return map.containsKey(name);
}
/**
Thanks & Regards
Vipin Menon
More information about the core-libs-dev
mailing list