RFR(S) : 8211977 : move testlibrary tests into one place

[Erik Joelsson]

On 2020-06-15 08:12, Magnus Ihse Bursie wrote:
> A few comments:
>
> This seems like code copied from elsewhere:
>
>   57 # This evaluation is expensive and should only be done if this 
> target was
>   58 # explicitly called.
>   59 ifneq ($(filter build-test-libtest-jtreg-native, $(MAKECMDGOALS)), )
>
> I don't agree that this is an expensive evaluation. Furthermore, the 
> makefile is only called for building the testlib and for making 
> images, so in worst case it's just the image part that would get a 
> penalty (although I highly doubt there is any).
>
This construct was added by me in the original file he copied from, so 
Igor is just following existing patterns. The SetupTestFilesCompilation 
calls result in rather big $(shell find...) calls. If you want to keep 
rebuilds of "make images" as fast as possible, these are certainly 
relevant optimizations.

/Erik

>   82 $(eval $(call SetupCopyFiles,COPY_LIBTEST_JTREG_NATIVE, \
>
> Please use space after comma.
>
> /Magnus
>
> On 2020-06-13 05:38, Igor Ignatyev wrote:
>> adding build-dev
>>
>>> On Jun 12, 2020, at 8:36 PM, Igor Ignatyev 
>>> <igor.ignatyev at oracle.com> wrote:
>>>
>>> http://cr.openjdk.java.net/~iignatyev//8211977/webrev.00/
>>>> 796 lines changed: 200 ins; 588 del; 8 mod;
>>> Hi all,
>>>
>>> could you please review this small patch which puts all tests for 
>>> testlibrary classes into one location under /test/lib-test?
>>>
>>> besides moving tests from test/jdk/lib/testlibrary and 
>>> test/hotspot/jtreg/testlibrary_tests to test/lib-test the patch also
>>> - problem lists HexPrinterTest.java on windows due to JDK-8247521
>>> - introduces make targets to build native parts for the tests in 
>>> test/lib-test (needed b/c one test has a native part)
>>> - adds randomness k/w to test/lib-test (as it's used by 
>>> RandomGeneratorTest.java)
>>> - makes Test class used by TestNativeProcessBuilder a static nested 
>>> class of TestNativeProcessBuilder
>>> - updates LingeredAppTest to use @build instead of @compile and adds 
>>> necessary @library tag
>>> - removes AssertsTest.java, OutputAnalyzerTest.java from 
>>> test/hotspot/jtreg/testlibrary_tests as they are either identical or 
>>> lesser that the same tests from test/jdk/lib/testlibrary/
>>> - merges 
>>> test/hotspot/jtreg/testlibrary_tests/OutputAnalyzerTest.java and  
>>> test/jdk/lib/testlibrary/OutputAnalyzerTest.java (effectively adds 
>>> test cases for `firstMatch` to the superier copy from 
>>> test/jdk/lib/testlibrary)
>>>
>>> webrev: http://cr.openjdk.java.net/~iignatyev//8211977/webrev.00/
>>> JBS: https://bugs.openjdk.java.net/browse/JDK-8211977
>>> testing: test/lib-test on {windows,linux,macosx}-x64
>>>
>>> Thanks,
>>> -- Igor
>>>
>>>
>