RFR: 8247532: Records deserialization is slow

Peter Levart peter.levart at gmail.com
Wed Jun 17 05:44:28 UTC 2020


Hi Chris,


On 6/17/20 12:31 AM, Peter Levart wrote:
>> I did however notice that there is just a single test, 
>> DefaultValuesTest, that exercises different stream shapes for the 
>> same class in the stream. Would be good to expand coverage in this 
>> area, but of course some lower-level test-specific building blocks 
>> will be needed help build the specially crafted byte streams - I can 
>> help with this.
>>
>> Overall I think that this change is good.
>>
>> -Chris.
>>
> If there is a way for a test to compile several versions of the same 
> (record) class and then produce byte streams with it, then we could 
> simulate various class-evolution cases (field missing, surplus field, 
> change of field type, etc...) without crafting the bytestream by hand. 
> WDYT? 


I have a better idea. The test could contain several different classes 
with different names that would be used to generated variations of 
serialized stream. Such streams could then be "patched" so they would 
contain the common target class name and then used to (attempt to) 
deserialize the target class. I'll try to devise such test...


Regards, Peter




More information about the core-libs-dev mailing list