RFR [15] 8247789: Remove use of reflection from test/jdk/java/io/Serializable/records/StreamRefTest.java

Roger Riggs Roger.Riggs at oracle.com
Thu Jun 18 13:56:44 UTC 2020


Hi Chris,

It may be prudent to check that the current value in the byte array is 
the one you expect
before changing it.
That would help catch tests if something else changes the contents of 
the stream.

Otherwise looks good.

Thanks, Roger



On 6/18/20 9:28 AM, Chris Hegarty wrote:
> This is a small change to remove the use of reflection to fabricate
> "bad" serial data - in order to verify constructor invariants for
> record serialization tests. Instead, it is straight forward to just
> modify a single value in the byte stream, that results in the same.
>
> https://cr.openjdk.java.net/~chegar/8247789/webrev/
>
> -Chris.
>



More information about the core-libs-dev mailing list