RFR: [15, docs] JDK-8247899, HTML errors and warnings in threadPrimitiveDeprecation.html

Lance @ Oracle lance.andersen at oracle.com
Fri Jun 19 00:30:25 UTC 2020


Looks reasonable Jon 

Best,
Lance



Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering 
1 Network Drive 
Burlington, MA 01803
Lance.Andersen at oracle.com
Sent from my iPad

> On Jun 18, 2020, at 8:19 PM, Jonathan Gibbons <jonathan.gibbons at oracle.com> wrote:
> 
> Please review this trivial fix to some minor issues reported by doclint.
> 
> In the first change, the `<hr>`  contained a hangover of some HTML 4 attributes
> which are not supported in HTML5. They are simply deleted.
> 
> In the second change, a paragraph just contained a comment. While it might
> be reasonable to just remove the paragraph tags surrounding the comment,
> the comment itself ("Body text ends here") is somewhat redundant, appearing
> as it does right before `</body>` and so the entire line is deleted.
> 
> -- Jon
> 
> JBS: https://bugs.openjdk.java.net/browse/JDK-8247899
> 
> Inline patch:
> 
> diff -r f80508232687 src/java.base/share/classes/java/lang/doc-files/threadPrimitiveDeprecation.html
> --- a/src/java.base/share/classes/java/lang/doc-files/threadPrimitiveDeprecation.html Thu Jun 18 16:21:34 2020 -0700
> +++ b/src/java.base/share/classes/java/lang/doc-files/threadPrimitiveDeprecation.html Thu Jun 18 17:10:24 2020 -0700
> @@ -282,7 +282,7 @@
>          }
>      }
>  </pre>
> -<hr size="3" noshade="noshade" />
> +<hr>
>  <h2>Can I combine the two techniques to produce a thread that may
>  be safely "stopped" or "suspended"?</h2>
>  Yes, it's reasonably straightforward. The one subtlety is that the
> @@ -324,6 +324,5 @@
>  described above, it needn't call <code>notify</code> as well, but it
>  still must be synchronized. This ensures that the target thread
>  won't miss an interrupt due to a race condition.
> -<p><!-- Body text ends here --></p>
>  </body>
>  </html>
> 


More information about the core-libs-dev mailing list