RFR 8245302: Upgrade LogRecord to support long thread ids and remove its usage of ThreadLocal
Rahul Yadav
rahul.r.yadav at oracle.com
Fri Jun 19 09:00:59 UTC 2020
Thank you Alan, updated webrev.
webrev :
http://cr.openjdk.java.net/~ryadav/webrev_8245302/webrev.00/index.html
- rahul
On 19/06/2020 08:43, Alan Bateman wrote:
> On 18/06/2020 23:37, Rahul Yadav wrote:
>> Hi Alan,
>>
>> Thank you for the feedback.I have updated the webrev.
>>
>> webrev :
>> http://cr.openjdk.java.net/~ryadav/webrev_8245302/webrev.00/index.html
> This looks quite good.
>
> The comment in shortShortID has "any positive long less than
> Integer.MAX_VALUE" but it's actually <= MAX_VALUE.
>
> I don't think MIN_SEQUENTIAL_THREAD_ID is used so I assume it can be
> removed.
>
> The @return for setLongThreadID has a description "Log Record" but
> this should "this LogRecord".
>
> Can you update SerializeLogRecordTest with clear instructions on how
> to generate the stream? This will help future maintainers that may
> have to update this test.
>
> -Alan
More information about the core-libs-dev
mailing list