RFR 8245302: Upgrade LogRecord to support long thread ids and remove its usage of ThreadLocal
Rahul Yadav
rahul.r.yadav at oracle.com
Fri Jun 19 10:49:24 UTC 2020
Hi Daniel,
Thank you for the feedback.
I have added the new case for thread id > Integer.MAX_VALUE.
have updated comments/names and string to JDK 16.
I will follow-up with a new JBS issue for the backport
webrev :
http://cr.openjdk.java.net/~ryadav/webrev_8245302/webrev.00/index.html
- rahul
On 19/06/2020 09:58, Daniel Fuchs wrote:
> Hi Rahul,
>
> This looks very good.
>
> I have some comments regarding the SerializeLogRecord test:
>
> - the test speaks of JDK 15 at several places: is it really JDK 15, or
> should it be JDK 16? I mean - was the serialized bytes generated
> before your fix or after?
>
> - the generate() method (no args) should probably have a test case
> where a log record has a long thread id > Integer.MAX_VALUE.
>
> - it might be good to work on a version of this test that could
> be backported to JDK 15 (and 11) to verify that a LogRecord
> serialized with JDK 16 can be deserialized in those versions.
> You should probably log a JBS issue to follow-up on that.
>
> best regards,
>
> -- daniel
>
>
> On 18/06/2020 23:37, Rahul Yadav wrote:
>> Hi Alan,
>>
>> Thank you for the feedback.I have updated the webrev.
>>
>> webrev :
>> http://cr.openjdk.java.net/~ryadav/webrev_8245302/webrev.00/index.html
>>
>> - rahul
More information about the core-libs-dev
mailing list