RFR: 8225251: Minimise import statements in jpackage sources

[Alexey Semenyuk]

Looks good.

- Alexey

On 6/19/2020 10:05 PM, alexander.matveev at oracle.com wrote:
> http://cr.openjdk.java.net/~almatvee/8225251/webrev.01/
>
> - Expended "import static org.junit.Assert.*" and "import static 
> jdk.incubator.jpackage.internal.StandardBundlerParam.*".
> - Fixed inconsistency between imported StandardBundlerParam or when 
> used directly. See 
> http://cr.openjdk.java.net/~almatvee/8225251/webrev.01/src/jdk.incubator.jpackage/macosx/classes/jdk/incubator/jpackage/internal/MacAppImageBuilder.java.frames.html 
> for example.
>
> Thanks,
> Alexander
>
> On 6/19/20 3:36 PM, Andy Herrick wrote:
>> I'm fine with it either way - the main thing is what you have done.
>>
>> /Andy
>>
>> On 6/19/2020 6:02 PM, alexander.matveev at oracle.com wrote:
>>> Hi Alexey,
>>>
>>> Andy mentioned in issue description not to expend static imports, 
>>> this is why all static imports were not expended. I can expend them 
>>> or we can keep as is. I am fine with either way. Andy any comments 
>>> why we do not need to expend static imports?
>>>
>>> Thanks,
>>> Alexander
>>>
>>> On 6/19/20 10:49 AM, Alexey Semenyuk wrote:
>>>> This is how they were ut in unit tests initially. I'm OK either 
>>>> way, just wanted to double check these imports were not overlooked.
>>>>
>>>> - Alexey
>>>>
>>>> On 6/19/2020 12:30 PM, Kevin Rushforth wrote:
>>>>> That a reasonably common pattern in JUnit tests, but expanding 
>>>>> them to individual static imports is, of course, fine as well.
>>>>>
>>>>> -- Kevin
>>>>>
>>>>>
>>>>> On 6/19/2020 9:08 AM, Alexey Semenyuk wrote:
>>>>>> Alexander,
>>>>>>
>>>>>> There is still
>>>>>> ---
>>>>>> import static org.junit.Assert.*;
>>>>>> ---
>>>>>> in unit tests. Is this intended?
>>>>>>
>>>>>> - Alexey
>>>>>>
>>>>>> On 6/19/2020 4:46 AM, alexander.matveev at oracle.com wrote:
>>>>>>> Please review the jpackage fix for bug [1] at [2].
>>>>>>>
>>>>>>> Cleanup import statements.
>>>>>>>
>>>>>>> [1] https://bugs.openjdk.java.net/browse/JDK-8225251
>>>>>>> [2] http://cr.openjdk.java.net/~almatvee/8225251/webrev.00/
>>>>>>>
>>>>>>> Thanks,
>>>>>>> Alexander
>>>>>>
>>>>>
>>>>
>>>
>