RFR 8248184: AMPM_OF_DAY doc fix in ChronoField

naoto.sato at oracle.com naoto.sato at oracle.com
Wed Jun 24 00:47:18 UTC 2020


Thanks, Brian and Lance.

I forgot to update the copyright year. Pushed the changeset with the 
year update.

Naoto

On 6/23/20 3:09 PM, Lance Andersen wrote:
> +1
> 
> Best
> Lance
> ------------------
> 
> 
> 
> Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
> Oracle Java Engineering
> 1 Network Drive
> Burlington, MA 01803
> Lance.Andersen at oracle.com <mailto:Lance.Andersen at oracle.com>
> 
> 
> 
> 
>> On Jun 23, 2020, at 5:44 PM, naoto.sato at oracle.com 
>> <mailto:naoto.sato at oracle.com> wrote:
>>
>> Hi,
>>
>> Please review this small doc fix for the following issue:
>>
>> https://bugs.openjdk.java.net/browse/JDK-8248184
>>
>> The proposed patch is here:
>>
>> --- 
>> old/src/java.base/share/classes/java/time/temporal/ChronoField.java 
>> 2020-06-23 14:43:43.000000000 -0700
>> +++ 
>> new/src/java.base/share/classes/java/time/temporal/ChronoField.java 
>> 2020-06-23 14:43:43.000000000 -0700
>> @@ -270,7 +270,7 @@
>>      * The value is validated from 0 to 11 in strict and smart mode.
>>      * In lenient mode the value is not validated. It is combined with
>>      * {@code AMPM_OF_DAY} to form {@code HOUR_OF_DAY} by multiplying
>> -     * the {AMPM_OF_DAY} value by 12.
>> +     * the {@code AMPM_OF_DAY} value by 12.
>>      * <p>
>>      * See {@link #CLOCK_HOUR_OF_AMPM} for the related field that 
>> counts hours from 1 to 12.
>>      */
>> @@ -334,7 +334,7 @@
>>      * The value is validated from 0 to 1 in strict and smart mode.
>>      * In lenient mode the value is not validated. It is combined with
>>      * {@code HOUR_OF_AMPM} to form {@code HOUR_OF_DAY} by multiplying
>> -     * the {AMPM_OF_DAY} value by 12.
>> +     * the {@code AMPM_OF_DAY} value by 12.
>>      */
>>     AMPM_OF_DAY("AmPmOfDay", HALF_DAYS, DAYS, ValueRange.of(0, 1), 
>> "dayperiod"),
>>
>> Naoto
> 


More information about the core-libs-dev mailing list