RFR: 8239365: ProcessBuilder/Basic.java test modifications for AIX execution
Thomas Stüfe
thomas.stuefe at gmail.com
Tue Mar 3 10:52:10 UTC 2020
This is why I always was against handing up the result of strerror to the
user :) The same problem we would have when running with different locales.
We should have a platform agnostic string table in the java lib for that
purpose...
As for the test, looks good, but I personally would shorten the AIX
patterns a bit or maybe try to find a short form fitting all platforms
(e.g. "[Pp]ermission").
But thats just idle bikeshedding, lets see what others think.
Cheers Thomas
On Tue, Mar 3, 2020 at 11:43 AM Adam Farley8 <adam.farley at uk.ibm.com> wrote:
> Hi All,
>
> Reviews and sponsor requested for a small test change.
>
> Short version: When an AIX machine has the file set "bos.msg.en_US.rte",
> the error messages are not in a form that the test expects, causing
> failure.
>
> The simplest option appears to be adding the second potential form of the
> message into the regex (see webrev).
>
> http://cr.openjdk.java.net/~afarley/8239365.1/webrev/
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8239365
>
> Best Regards
>
> Adam Farley
> IBM Runtimes
> Unless stated otherwise above:
> IBM United Kingdom Limited - Registered in England and Wales with number
> 741598.
> Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU
>
>
More information about the core-libs-dev
mailing list