RFR 8129841 Update comment for Java_java_net_Inet6AddressImpl_getHostByAddr
Vipin Mv1
vipinmv1 at in.ibm.com
Tue Mar 3 10:53:44 UTC 2020
Hi All,
Please find the below changes for the issue https://bugs.openjdk.java.net/browse/JDK-8129841. Apart from the requested changes, I have made additional changes to the Signature where ever I found it incorrect.
Thanks
Vipin M V
diff -r 387369ff21a4 src/java.base/unix/native/libnet/Inet4AddressImpl.c
--- a/src/java.base/unix/native/libnet/Inet4AddressImpl.c Wed Feb 05 12:20:36 2020 -0300
+++ b/src/java.base/unix/native/libnet/Inet4AddressImpl.c Tue Mar 03 15:32:21 2020 +0530
@@ -218,7 +218,7 @@
/*
* Class: java_net_Inet4AddressImpl
* Method: getHostByAddr
- * Signature: (I)Ljava/lang/String;
+ * Signature: ([B)Ljava/lang/String;
*
* Theoretically the UnknownHostException could be enriched with gai error
* information. But as it is silently ignored anyway, there's no need for this.
diff -r 387369ff21a4 src/java.base/unix/native/libnet/Inet6AddressImpl.c
--- a/src/java.base/unix/native/libnet/Inet6AddressImpl.c Wed Feb 05 12:20:36 2020 -0300
+++ b/src/java.base/unix/native/libnet/Inet6AddressImpl.c Tue Mar 03 15:32:21 2020 +0530
@@ -413,7 +413,7 @@
/*
* Class: java_net_Inet6AddressImpl
* Method: getHostByAddr
- * Signature: (I)Ljava/lang/String;
+ * Signature: ([B)Ljava/lang/String;
*
* Theoretically the UnknownHostException could be enriched with gai error
* information. But as it is silently ignored anyway, there's no need for this.
@@ -668,7 +668,7 @@
/*
* Class: java_net_Inet6AddressImpl
* Method: isReachable0
- * Signature: ([bII[bI)Z
+ * Signature: ([BII[BII)Z
*/
JNIEXPORT jboolean JNICALL
Java_java_net_Inet6AddressImpl_isReachable0(JNIEnv *env, jobject this,
diff -r 387369ff21a4 src/java.base/windows/native/libnet/Inet4AddressImpl.c
--- a/src/java.base/windows/native/libnet/Inet4AddressImpl.c Wed Feb 05 12:20:36 2020 -0300
+++ b/src/java.base/windows/native/libnet/Inet4AddressImpl.c Tue Mar 03 15:32:21 2020 +0530
@@ -171,7 +171,7 @@
/*
* Class: java_net_Inet4AddressImpl
* Method: getHostByAddr
- * Signature: (I)Ljava/lang/String;
+ * Signature: ([B)Ljava/lang/String;
*
* Theoretically the UnknownHostException could be enriched with gai error
* information. But as it is silently ignored anyway, there's no need for this.
diff -r 387369ff21a4 src/java.base/windows/native/libnet/Inet6AddressImpl.c
--- a/src/java.base/windows/native/libnet/Inet6AddressImpl.c Wed Feb 05 12:20:36 2020 -0300
+++ b/src/java.base/windows/native/libnet/Inet6AddressImpl.c Tue Mar 03 15:32:21 2020 +0530
@@ -240,7 +240,7 @@
/*
* Class: java_net_Inet6AddressImpl
* Method: getHostByAddr
- * Signature: (I)Ljava/lang/String;
+ * Signature: ([B)Ljava/lang/String;
*
* Theoretically the UnknownHostException could be enriched with gai error
* information. But as it is silently ignored anyway, there's no need for this.
@@ -435,7 +435,7 @@
/*
* Class: java_net_Inet6AddressImpl
* Method: isReachable0
- * Signature: ([bII[bI)Z
+ * Signature: ([BII[BII)Z
*/
JNIEXPORT jboolean JNICALL
Java_java_net_Inet6AddressImpl_isReachable0(JNIEnv *env, jobject this,
More information about the core-libs-dev
mailing list