RFR(S): 8240734: ModuleHashes attribute not reproducible between builds

[Bernd Eckenfels]

Hello,

I wonder why there are two times the same logic in internal public static methods. Maybe that could be consolidated as well?

Gruss
Bernd
--
http://bernd.eckenfels.net
________________________________
Von: core-libs-dev <core-libs-dev-bounces at openjdk.java.net> im Auftrag von Yangfei (Felix) <felix.yang at huawei.com>
Gesendet: Tuesday, March 10, 2020 3:54:54 AM
An: core-libs-dev at openjdk.java.net <core-libs-dev at openjdk.java.net>
Betreff: RFR(S): 8240734: ModuleHashes attribute not reproducible between builds

Hi,

  We found module-info.class in java.base.jmod is not always consistent across different builds.
  The ModuleHashes attribute in this module-info.class is not reproducible between builds.
  Patch fixes the issue by using TreeMap instead of HashMap when computing ModuleHashes.

  Bug: https://bugs.openjdk.java.net/browse/JDK-8240734
  Webrev: http://cr.openjdk.java.net/~fyang/8240734/webrev.00/

  Passed tier1 test.  Please review.

Thanks,
Felix