RFR: 8240725: Some functions might not work with CJK character

naoto.sato at oracle.com naoto.sato at oracle.com
Tue Mar 10 19:16:54 UTC 2020


Ah, thanks Martin. Never mind about the comment wrt free(NULL) then.

Naoto

On 3/10/20 11:30 AM, Martin Buchholz wrote:
> 
> 
> On Tue, Mar 10, 2020 at 10:08 AM <naoto.sato at oracle.com 
> <mailto:naoto.sato at oracle.com>> wrote:
> 
> 
>     Then I noticed (should have noticed in the first place, sorry) that the
>     error handling in canonicalize_md.c is incorrect (unrelated to your
>     change). All error cases "goto finish" which would end up "free(NULL)"
>     in some cases, e.g.
> 
> 
> FYI  free(NULL) is a no-op
> https://pubs.opengroup.org/onlinepubs/9699919799/functions/free.html 
> <https://urldefense.com/v3/__https://pubs.opengroup.org/onlinepubs/9699919799/functions/free.html__;!!GqivPVa7Brio!MXhUyNpsvJ4iD_99hk8QHPJmUXFZBmNM5LsbOXSquI3mrLUXNfXd2SGXk9mT7zz-$>


More information about the core-libs-dev mailing list