[15] RFR: 8241130: com.sun.jndi.ldap.EventSupport.removeDeadNotifier: java.lang.NullPointerException

[Chris Yin]

Thank you, Daniel

Regards,
Chris

> On 19 Mar 2020, at 7:54 PM, Daniel Fuchs <daniel.fuchs at oracle.com> wrote:
> 
> Hi Chris,
> 
> On 19/03/2020 07:23, Chris Yin wrote:
>> [...] Per javadoc from EventContext and EventDirContext interface which implemented by LdapCtx that will call EventSupport, "NamingException should be thrown if a problem was encountered" when add/remove NamingListener, that requires us to construct a meaningful NamingException and get back to user to indicate problem encountered instead of 'simple null check’ + skip (like current fix), certainly, where is the suitable place to put the logic (maybe LdapCtx or EventSupport) still to be determined. [...]
> 
> OK, I can see where you're going. Let's handle that separately then.
> 
> I could verify that your patch indeed solves the intermittent
> test failure.
> 
> You have my review!
> 
> best regards,
> 
> -- daniel
> 
>>> Also you could had the @bug 8241130
>>> to RemoveNamingListenerTest.java, since the test can be used
>>> to verify the fix (if run often enough).
>> Sure, updated webrev as below, thanks
>> http://cr.openjdk.java.net/~xyin/8241130/webrev.01/
>