[15] RFR: 8241311: Move some charset mapping tests from closed to open

[Ichiroh Takiguchi]

Hello Naoto.

I tested webrev.06 code.
It's fine, thanks.

I'm interested in about @module for these testcases.
I think webrev.04 code worked via jtreg.
I could not see any warning.
At this case, @module is required ?

Thanks,
Ichiroh Takiguchi

On 2020-03-24 10:06, naoto.sato at oracle.com wrote:
> Hi Takiguchi-san,
> 
> On 3/23/20 5:48 AM, Ichiroh Takiguchi wrote:
>> Hello Naoto.
>> 
>> I'm not reviewer, but I have a concern about following code
>> on test/jdk/sun/nio/cs/mapping/TestConv.java
>> ======
>>   98             } catch (Exception ex) {
>>   99                 System.out.println("Exception 
>> thrown while testing " + encoding);
>> 100                 ex.printStackTrace();
>> 101                 return;
>> 102             }
>> ======
>> 
>> 3 stack trace (java.io.UnsupportedEncodingException) were displayed 
>> against following encodings:
>>    MS50221_0208, MS50221_0212, MS932_0208
>> 
>> I think only UnsupportedEncodingException should be caught.
>> The other exception should be handled as error.
>> 
>> What do you think ?
> 
> Good catch. I believe the test logic that assumes the file name is the
> charset name is simply wrong. I added the check whether the input
> charset name is supported or not, and only do the test if the charset
> is supported:
> 
> http://cr.openjdk.java.net/~naoto/8241311/webrev.05/
> 
> Naoto
> 
>> 
>> Thanks,
>> Ichiroh Takiguchi
>> 
>> On 2020-03-21 01:21, naoto.sato at oracle.com wrote:
>>> Hello,
>>> 
>>> Please review the fix to the following issue:
>>> 
>>> https://bugs.openjdk.java.net/browse/JDK-8241311
>>> 
>>> The proposed changeset is located at:
>>> 
>>> https://cr.openjdk.java.net/~naoto/8241311/webrev.04/
>>> 
>>> This is simply to move some test cases that have been in closed
>>> repository into open repository.
>>> 
>>> Naoto