[15] RFR: 8241311: Move some charset mapping tests from closed to open

naoto.sato at oracle.com naoto.sato at oracle.com
Tue Mar 24 16:30:21 UTC 2020


Thanks again. I will look into it and come up with better migration of 
those tests.

Naoto

On 3/23/20 9:45 PM, Amy Lu wrote:
> Thank you Naoto for the quick update.
> 
> Just more findings ...(sorry for not sending earlier)
> 
> CoderTest.java
> Looks like this test has already been migrated (with enhancement) to the 
> 'open' [1] in JDK-8186801 [2] [3].
> 
> I'm not sure whether the data files that used by TestCharsetMapping.java 
> can be leveraged by other two tests, but worth checking.
> 
> Thanks,
> Amy
> 
> [1] 
> http://hg.openjdk.java.net/jdk/jdk/file/tip/test/jdk/sun/nio/cs/TestCharsetMapping.java 
> 
> [2] https://bugs.openjdk.java.net/browse/JDK-8186801
> [3] https://mail.openjdk.java.net/pipermail/nio-dev/2017-August/004427.html
> 
> 
> On 3/24/20 12:19 PM, naoto.sato at oracle.com wrote:
>> Hi Amy,
>>
>> Good point. Updated.
>>
>> https://cr.openjdk.java.net/~naoto/8241311/webrev.06/
>>
>> Naoto
>>
>> On 3/23/20 7:43 PM, Amy Lu wrote:
>>> Hi, Naoto
>>>
>>> CoderTest.java TestConv.java
>>> Should they also include @modules jdk.charsets ?
>>>
>>> Thanks,
>>> Amy
>>>
>>> On 3/21/20 12:21 AM, naoto.sato at oracle.com wrote:
>>>> Hello,
>>>>
>>>> Please review the fix to the following issue:
>>>>
>>>> https://bugs.openjdk.java.net/browse/JDK-8241311
>>>>
>>>> The proposed changeset is located at:
>>>>
>>>> https://cr.openjdk.java.net/~naoto/8241311/webrev.04/
>>>>
>>>> This is simply to move some test cases that have been in closed 
>>>> repository into open repository.
>>>>
>>>> Naoto
>>>
> 


More information about the core-libs-dev mailing list