[PING] RFR(s): 8176894 Provide specialized implementation for default methods putIfAbsent, computeIfAbsent, computeIfPresent, compute, merge in TreeMap

Thomas Stüfe thomas.stuefe at gmail.com
Wed Mar 25 06:01:46 UTC 2020


On Tue, Mar 24, 2020 at 10:25 PM Florian Weimer <fw at deneb.enyo.de> wrote:

> * Thomas Stüfe:
>
> > Hi Tagir,
> >
> > nice work. Only a partwise review for TreeMap.java, did not yet look at
> the
> > tests.
> >
> > remapValue:
> >
> >  711         } else {
> >  712             // replace old mapping
> >  713             t.value = newValue;
> >  714             return newValue;
> >  715         }
> >
> > Should we increase the modification count here?
>
> It's not a structural modification, is it?  Only structural
> modifications increase the modification count, as far as I can see.
>

You may be right.

..Thomas


More information about the core-libs-dev mailing list