RFR: 8241055: Regex Grapheme Matcher Performance Depends too much on Total Input Sequence Size

naoto.sato at oracle.com naoto.sato at oracle.com
Thu Mar 26 21:14:51 UTC 2020


Hi Philipp,

I looked at the patch, and it looks good to me. As to the test case, 
since it is measuring the performance, I would make it in a JMH test. 
Maybe you would want to put it similar to 
open/test/micro/org/openjdk/bench/java/util/regex/PatternBench.java

Minor suggestion: I would rather rename "getGraphemeType()" to just 
"getType()", as it is simply retrieving the character type.

Naoto

On 3/21/20 7:58 AM, Philipp Kunz wrote:
> Hi,
> 
> Any opinions on the attached patch or someone tempted to sponsor it?
> 
> Regards,
> Philipp


More information about the core-libs-dev mailing list