RFR: JDK-8237490: [macos] Add support notarizing jpackage app-image and dmg
Alexey Semenyuk
alexey.semenyuk at oracle.com
Fri Mar 27 22:57:38 UTC 2020
Agree with Alexander's findings. The rest looks good.
- Alexey
On 3/27/2020 5:18 PM, Alexander Matveev wrote:
> Hi Andy,
>
> http://cr.openjdk.java.net/~herrick/8237490/webrev.05/src/jdk.incubator.jpackage/macosx/classes/jdk/incubator/jpackage/internal/MacAppImageBuilder.java.frames.html
>
> Line 819,857,902 - Looks like temp debug log message. Remove it or
> align with rest of code.
>
> http://cr.openjdk.java.net/~herrick/8237490/webrev.05/src/jdk.incubator.jpackage/macosx/classes/jdk/incubator/jpackage/internal/resources/MacResources.properties.frames.html
>
> Line 70 - Capital F.
>
> Since we added "--timestamp" and "--options runtime" to codesign,
> will it work with older Xcode and macOS we planning to support?
>
> Do we need any adjustments to signing tests we have?
>
> Otherwise looks fine.
>
> Thanks,
> Alexander
>
> On 3/27/20 12:35 PM, Andy Herrick wrote:
>> Please review the fix to issue [1] at [2].
>>
>> This change enables notarization on Mac for dmg images and app-image
>> zip files.
>>
>> /Andy
>>
>> [1]: https://bugs.openjdk.java.net/browse/JDK-8237490
>>
>> [2]: http://cr.openjdk.java.net/~herrick/8237490
>>
>
More information about the core-libs-dev
mailing list