JDK 15 RF(pre)R of JDK-8241374: add Math.absExact

Joe Darcy joe.darcy at oracle.com
Mon Mar 30 16:31:53 UTC 2020


Hi Brian and Chris,

I was considering adding such as JLS link myself; I'll work one in and 
post a revised webrev.

Thanks,

-Joe

On 3/30/2020 9:29 AM, Brian Burkhalter wrote:
> Hi Joe,
>
>> On Mar 30, 2020, at 6:31 AM, Chris Hegarty <chris.hegarty at oracle.com 
>> <mailto:chris.hegarty at oracle.com>> wrote:
>>
>>> Full webrev for review include including tests:
>>>
>>> http://cr.openjdk.java.net/~darcy/8241374.0/
>>>
>>> and the companion CSR:
>>>
>>> https://bugs.openjdk.java.net/browse/JDK-8241805
>>
>> Looks good to me.
>
> Likewise.
>
>> I do like the explanatory paragraph about the asymmetry in the range 
>> of two's complement integer values. An alternative, or addition, 
>> would be a link to JLS 4.2.1 - Integral Types and Values [1], which 
>> shows the asymmetry from a language perspective.
>
> I also like this suggestion.
>
> Brian
>
>> -Chris.
>>
>> [1]https://docs.oracle.com/javase/specs/jls/se14/html/jls-4.html#jls-4.2.1
>


More information about the core-libs-dev mailing list