RFR(XS): 8244495: Some jlink tests crash on Windows after JDK-8237750

[David Holmes]

On 7/05/2020 12:04 pm, Daniel D. Daugherty wrote:
> On 5/6/20 9:01 PM, Yumin Qi wrote:
>> Hi,
>>   Please review the fix for
>>   bug: https://bugs.openjdk.java.net/browse/JDK-8244495
>>   webrev: http://cr.openjdk.java.net/~minqi/8244495/webrev/
> 
> src/java.base/share/native/libjimage/imageDecompressor.cpp
>      No comments.
> 
> Thumbs up. I think this qualifies as a trivial fix so you can push
> this fix without waiting for 24 hours.

Especially when it already has 4 reviewers :)

David

> Dan
> 
> 
>>
>> Tests tools/jlink/JLinkTest.javaand tools/jlink/basic/BasicTest.java 
>> failed after 8237750 pushed. The fix of 8237750 changed default 
>> behavior of loading zip library to on-demand loading. jlink (and 
>> jimage) assumes that zip library was loaded already, so call to 
>> FindEntry caused ACCESS_VIOLATION on Windows. This is a Windows 
>> specific problem. GetModuleHandle is used on the library already 
>> loaded and won't load the library if it's not loaded.
>>
>>    Tests: tier1-2 passed.
>>
>>   Thanks
>>   Yumin
>