RFR: 8244224: Implementation of JEP 381: Remove the Solaris and SPARC Ports - (core libraries)

Mikael Vidstedt mikael.vidstedt at oracle.com
Thu May 7 04:45:34 UTC 2020



> On May 5, 2020, at 5:42 AM, Daniel Fuchs <daniel.fuchs at oracle.com> wrote:
> 
> Hi Mikael,
> 
> I spotted another place where a residual reference to Solaris
> remains in a comment:
> src/java.base/unix/native/libnet/PlainSocketImpl.c
> 
> 857 #if defined(_AIX)
> 858         if (errno == EINVAL) {
> 859             // On Solaris setsockopt will set errno to EINVAL if the socket
> 860             // is closed. The default error message is then confusing

Fixed in the upcoming webrev!

> Otherwise I had a look at the networking related files and
> the changes seemed reasonable to me.

Thanks a lot for the review!

Cheers,
Mikael



More information about the core-libs-dev mailing list