RFR [XXS] : 8244183: linker error jpackageapplauncher on Windows 32bit

Baesken, Matthias matthias.baesken at sap.com
Thu May 7 05:16:09 UTC 2020


Sorry , there was still an issue with rev. 0 ,  I had to adjust  the signature of wmain
As well to get around the link errors .

http://cr.openjdk.java.net/~mbaesken/webrevs/8244183.1/

This builds on both windows 64 bit and 32 bit .

Best regards, Matthias

From: Thomas Stüfe <thomas.stuefe at gmail.com>
Sent: Freitag, 1. Mai 2020 08:20
To: Baesken, Matthias <matthias.baesken at sap.com>
Cc: core-libs-dev <core-libs-dev at openjdk.java.net>; Doerr, Martin <martin.doerr at sap.com>
Subject: Re: RFR [XXS] : 8244183: linker error jpackageapplauncher on Windows 32bit

You have enough reviews now, but thanks for fixing this.

..Thomas

On Thu, Apr 30, 2020 at 4:15 PM Baesken, Matthias <matthias.baesken at sap.com<mailto:matthias.baesken at sap.com>> wrote:
Hello, please look into this small fix for a link error we faced on Windows 32bit.

Currently we run into this link error :
jpackageapplauncher

* For target support_native_jdk.incubator.jpackage_jpackageapplauncher_BUILD_JPACKAGE_APPLAUNCHEREXE_link:
LINK : fatal error LNK1561: entry point must be defined

looks like the wWinMain signature in
src\jdk.incubator.jpackage\windows\native\applauncher\WinLauncher.cpp
has to be adjusted.


Bug/webrev :

https://bugs.openjdk.java.net/browse/JDK-8244183

http://cr.openjdk.java.net/~mbaesken/webrevs/8244183.0/


Thanks, Matthias


More information about the core-libs-dev mailing list