RFR: JDK-8209774 - [TESTBUG]Refactor shell test javax/xml/jaxp/common/8035437/run.sh to java

[Daniel Fuchs]

Hi Fernando,

I believe that if you simply move the patched file
under a directory named javax.xml, then you can get
rid of all the @compile in the test.
Starting from your patch:

cd  test/jdk/javax/xml/jaxp/common/8035437
mkdir java.xml
hg move org javax.xml
hg move com javax.xml

then:

   31 /*
   32  * @test
   33  * @bug 8035437
   34  * @summary Tests that java.lang.AbstractMethodError is not thrown 
when
   35  * serializing improper version of DocumentImpl class.
   36  * @library /test/lib
       * @modules javax.xml/org.w3c.dom
       *          javax.xml/com.sun.org.apache.xerces.internal.dom
   40  * @run main/othervm --patch-module java.xml=${test.class.path} 
AbstractMethodErrorTest
   41  */

(not 100% sure the @modules is even needed)

best regards,

-- daniel

On 08/05/2020 13:58, Fernando Guallini wrote:
> Hi all,
> 
> Please, review the following change:
> 
> webrev: http://cr.openjdk.java.net/~fyuan/fernando/8209774/webrev.00/ <http://cr.openjdk.java.net/~fyuan/fernando/8209774/webrev.00/>
> Testbug: https://bugs.openjdk.java.net/browse/JDK-8209774 <https://bugs.openjdk.java.net/browse/JDK-8209774>
> 
> Change details:
> - Refactor shell test to java
> 
> That test was originally created to check XERCESJ-1007 bug fix, that java.lang.AbstractMethodError is not thrown when patching JDK boot class DocumentImpl with its own.
> 
> Kind regards,
> Fernando
>