JDK-8226810: An other case and a small change suggestion

[naoto.sato at oracle.com]

Ditto. Good catch!

I am not sure the fix would address the issue in 8226810 (cannot confirm 
it either, as my Windows box is at my office where I cannot enter at the 
moment :-), but this definitely looks like a bug. I would change the 
additional line to "strcpy(ret+2, "1252");" as Cp is copied in the 
following switch.

Naoto



On 5/7/20 5:50 AM, Alan Bateman wrote:
> On 07/05/2020 12:37, Johannes Kuhn wrote:
>> :
>>
>> In the end, I don't know what causes the bug, or how I can replicate it.
>> I think I did find a likely suspect.
> Good sleuthing. I don't what the conditions are for GetLocaleInfo to 
> fail but it does look like that would return possibly non-terminated 
> garbage starting with "CP" so we should at least fix that.
> 
> The issue in JDK-8226810 might be something else. One of the submitters 
> to that issue did engage and provided enough information to learn that 
> the locale is zh_CN and also reported that it was failing for GB18030. 
> GB18030 is not in java.base so that at least explained that report.
> 
> -Alan