RFR: 8193066: Avoid use of capturing lambdas in JarFile

Claes Redestad claes.redestad at oracle.com
Mon May 11 16:37:14 UTC 2020


Hi Lance,

thank you for reviewing!

/Claes

On 2020-05-11 18:01, Lance Andersen wrote:
> Hi Claes,
> 
> I think this looks good.  Thank you for making JarFile zippier ;-)
> 
>> On May 11, 2020, at 5:50 AM, Claes Redestad <claes.redestad at oracle.com 
>> <mailto:claes.redestad at oracle.com>> wrote:
>>
>> Hi,
>>
>> lambdas used in the interaction between JarFile and ZipFile can be
>> avoided by having ZipFile call a shared secret in JarFile to create a
>> JarFileEntry when appropriate. This removes an allocation per lookup.
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8193066
>> Webrev: http://cr.openjdk.java.net/~redestad/8193066/open.00/
>>
>> Testing: tier1-2, verified a small per-op speed-up, significantly so
>>         for negative lookups and during startup/warmup (10-20%
>>         improvements when interpreting)
>>
>> Thanks!
>>
>> /Claes
> 
> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
> <http://oracle.com/us/design/oracle-email-sig-198324.gif><http://oracle.com/us/design/oracle-email-sig-198324.gif>
> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| 
> Principal Member of Technical Staff | +1.781.442.2037
> Oracle Java Engineering
> 1 Network Drive
> Burlington, MA 01803
> Lance.Andersen at oracle.com <mailto:Lance.Andersen at oracle.com>
> 
> 
> 


More information about the core-libs-dev mailing list