RFR: JDK-8244634:, LoadLibraryW failed from tools/jpackage tests after JDK-8242302

[Alexander Matveev]

Hi Alexey,

Updating PATH does not look like good solution to me. Did you try to 
load jli.dll by specifying full path to jli.dll when calling LoadLibary? 
If it does not work, then for AddDllDirectory() did you used 
LoadLibrary() or LoadLibraryEx() with LOAD_LIBRARY_SEARCH_USER_DIRS? 
According to doc you need to use LoadLibraryEx() with flag when using 
AddDllDirectory().

Thanks,
Alexander

On 5/11/2020 4:36 PM, Alexey Semenyuk wrote:
> Please review fix [2] for jpackage bug [1].
>
> Fix failure to load jli.dll from app launcher. The fix is to append 
> path to directory with jli.dll to PATH env variable and load jli.dll 
> with altered value of PATH if the first attempt to load jli.dll 
> without altering PATH fails.
>
> - Alexey
>
> [1] https://bugs.openjdk.java.net/browse/JDK-8244634
>
> [2] http://cr.openjdk.java.net/~asemenyuk/8244634/webrev.00
>